Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Change default value of
ntp.sync.rtc.set
tofalse
. The motivation of this change was a recent discussion with @Bucking-Horn that brought to light that there are systems where the RTC is expected to be set to local time (instead of UTC) for coexistence with other operating systems (such as Windows).This is not really a problem here as we also have
ntp.sync.rtc.utc
to control whether the RTC should be set to, well, UTC (true
) or local time (false
), however, there exists no standardized way to obtain if the RTC is meant to be set in local time or not. The RTC itself doesn't know this and, hence, cannot be queried. To avoid such conflicts, we decide to not set the RTC by default but only if users specifically want it. If they do, they can also set the UTC/localtime option.Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.