Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set RTC time by default #2090

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Don't set RTC time by default #2090

merged 1 commit into from
Oct 18, 2024

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Oct 18, 2024

What does this implement/fix?

Change default value of ntp.sync.rtc.set to false. The motivation of this change was a recent discussion with @Bucking-Horn that brought to light that there are systems where the RTC is expected to be set to local time (instead of UTC) for coexistence with other operating systems (such as Windows).

This is not really a problem here as we also have ntp.sync.rtc.utc to control whether the RTC should be set to, well, UTC (true) or local time (false), however, there exists no standardized way to obtain if the RTC is meant to be set in local time or not. The RTC itself doesn't know this and, hence, cannot be queried. To avoid such conflicts, we decide to not set the RTC by default but only if users specifically want it. If they do, they can also set the UTC/localtime option.


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER requested review from Bucking-Horn and a team October 18, 2024 18:30
@DL6ER DL6ER force-pushed the tweak/dont_set_rtc branch from feb3e5c to 015bf0f Compare October 18, 2024 18:31
@DL6ER DL6ER merged commit 31c9783 into development Oct 18, 2024
19 checks passed
@DL6ER DL6ER deleted the tweak/dont_set_rtc branch October 18, 2024 18:57
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants